QUERY · ISSUE

ntptime Feature request: Would like to have the ntp server configurable

openby hagenbuchopened 2023-06-14updated 2023-06-28

The timeserver is hardcoded n ntptime.py:

host = "pool.ntp.org"

I would prefer to have this configurable, for several reasons:

There might only be a local network where the node is
DNS might not be available in some cases and under some error conditions
One might as well use a numeric values
Coordinated time might be more important than a real interconnection for embedded devices often involved with logging.

I'm sorry I have no idea (yet) where to start to create a full pull request..

1 comment

massimosala · 2023-06-28

Hi Andreas

It isn't hard-coded.

It is weird they don't put the 'host' as a parameter of the function, but you can do this:

import ntptime
ntptime.host = "your choice"
ntptime.settime()

CANDIDATE · PULL REQUEST

specify NTP host to use in ntptime of ESP8266

closedby flo-rianopened 2020-01-13updated 2020-02-16

port-esp8266

The NTP host for ntptime is hardcoded wich is really not helpfull especially because a lot of ESP might be behind firewalls in private networks.

Assessment

S Sonnet · high

Both the issue and the PR address making the NTP host configurable rather than hardcoded to pool.ntp.org, with identical motivation (firewalls, private networks, DNS unavailability). However, they target different files in different repositories: the issue is in micropython-lib (extmod/ntptime.py) while the PR modifies ports/esp8266/modules/ntptime.py in the main micropython repo. The PR does not resolve the issue — even if merged, the micropython-lib ntptime.py would remain unchanged. The PR also does not reference the issue.

Suggested action

Link the two items for cross-reference. The micropython-lib issue (#682) remains open. If the ESP8266-specific PR (micropython#5536) is merged, note it as a partial precedent, but the fix needs to be applied to micropython-lib's ntptime.py independently.

ntptime Feature request: Would like to have the ntp server configurable

specify NTP host to use in ntptime of ESP8266

Keyboard