QUERY · ISSUE

Pin toggle function does not exist in ESP32.

openby 0wwafaopened 2025-01-17updated 2025-01-25

enhancementport-esp32

Port, board and/or hardware

esp32

MicroPython version

MicroPython v1.24.1 on 2024-11-29; Generic ESP32 module with ESP32

Reproduction

from machine import Pin
p=Pin(2, Pin.OUT)
p.toggle()

Expected behaviour

Toggling the pin :D

Observed behaviour

the toggle function is not implemented.

So I do:
p.value(not p.value())

But from the docs I thought it was implemented.

It would be nice to have it, for code clarity but also for speed.

Additional Information

No, I've provided everything above.

Code of Conduct

Yes, I agree

CANDIDATE · PULL REQUEST

doc: Document machine.Pin.toggle() method.

mergedby projectgusopened 2024-09-10updated 2024-09-25

docsport-samdport-mimxrtport-rp2

Summary

Document the pin.toggle() method that's available on some ports.

This is an amended version of the commit from #9653. Closes #9652.

Assessment

Q Qwen · high

The query (Issue #16603) requests implementation of Pin.toggle() for the ESP32 port, which is currently missing. The candidate (PR #15822) only adds documentation for Pin.toggle() on SAMD, MIMXRT, and RP2 ports. While both items concern the Pin.toggle() method, the PR does not implement the feature for ESP32 - it only documents it for other ports. The PR explicitly mentions it closes #9652 (a documentation request), not the implementation request in #16603. The PR provides context that toggle() exists on some ports but doesn't resolve the ESP32 implementation gap.

Suggested action

Keep issue #16603 open. The PR #15822 is unrelated to implementing toggle() for ESP32. Consider creating a new PR to implement Pin.toggle() for the ESP32 port, potentially following the pattern used in other ports.