← index #7132PR #197
Related · medium · value 2.260
QUERY · ISSUE

mpy-tool does not properly collect module names for imports

openby matejcikopened 2021-04-19updated 2024-09-13
needs-info

Consider an application that has the following module file:
foo/bar/quux.py

Put an import statement in some other file:

from foo.bar import quux

When freezing the module with mpy-tool.py, the names foo.bar and quux are collected. However:

  • foo.bar.quux is not collected, which will be created as a qstr at runtime, because sys.modules uses it as a key
  • neither foo nor bar is collected. bar will be created as a qstr at runtime, because the dict of foo needs to insert it as a key

Of course, if we use relative imports, there's a similar problem: in foo/bar/baz.py, from . import quux should (but can't really know to) also collect foo.bar.quux despite the string not existing anywhere in the file.

I'm not sure if this is something to solve in mpy-tool itself, or whether there should be a separate step that collects symbols in this way. But it seems that using file names to generate both the fully qualified module name and the individual components would be the right thing to do. (that is basically the workaround i'm using: generate all_modules.py that walk the filesystem and convert every py file name to import that.file.name, which collects "that.file.name", and that.file.name which collects "that"", "file" and "name")

CANDIDATE · PULL REQUEST

Implement modules as singletons Python semantics.

mergedby pfalconopened 2014-01-19updated 2014-07-10

In Python, importing module several times returns same underlying module
object. This also fixes import statement handling for builtin modules.

There're still issues:

  1. CPython exposes set of loaded modules as sys.modules, we may want to
    do that either.
  2. Builtin modules are implicitly imported, which is not really correct.
    We should separate registering a (builtin) module and importing a module.
    CPython keeps builtin module names in sys.builtin_module_names .

Keyboard

j / / n
next pair
k / / p
previous pair
1 / / h
show query pane
2 / / l
show candidate pane
c
copy suggested comment
r
toggle reasoning
g i
go to index
?
show this help
esc
close overlays

press ? or esc to close

copied