← index #9325Issue #18080
Related · medium · value 1.253
QUERY · ISSUE

rp2: rp2.asm_pio_encode incorrectly accepts 'pins' as src for 'wait'

openby ccanepaopened 2022-09-15updated 2026-03-19
bugport-rp2
  • https://docs.micropython.org/en/latest/library/rp2.html#module-rp2 specifies the pio asm syntax for 'wait' as
    wait(polarity, src, index) where 'src' one of (gpio, pin, irq)
  • The rp2040-datasheet.pdf similary uses (GPIO, PIN, IRQ)

The bug is that rp2.asm_pio_encode silently accepts the invalid src value 'pins'. It should raise an exception.

Incidentaly it encodes "wait(1, pins, 0)" the same as "wait(1, gpio, 0)"

demo code

import rp2
try:
    rp2.asm_pio_encode("wait(1, pins, 0)")
    exception_raised = False
except Exception:
    exception_raised = True

assert exception_raised
CANDIDATE · ISSUE

RP2040 PIO: Script fails on some GPIO numbers

openby peterhinchopened 2025-09-15updated 2026-03-25
bug

Port, board and/or hardware

RP Pico (RP2040)

MicroPython version

MicroPython v1.26.1 on 2025-09-11; Raspberry Pi Pico with RP2040

Reproduction

Link GPIO 1-17, attach a scope/LA to GPIO 2, and run the following:

from machine import Pin, PWM
import rp2
import time

inp = Pin(0, Pin.IN)
jmp = Pin(1, Pin.IN)
opp = Pin(2, Pin.OUT, value=1)
pwm = PWM(Pin(17))  # Link GPIO 17 to GPIO 1
pwm.freq(1000)
pwm.duty_u16(0xFFFF // 2)

@rp2.asm_pio(out_init=rp2.PIO.OUT_LOW) 
def sm_test():
    set(x, 0)
    wrap_target()
    wait(0, pins, 1)  # Wait for GPIO 1 to go low
    mov(osr, x)  # Ouput==0 while input==0
    out(pins, 1)
    label("loop")  # Loop until jump pin goes high
    jmp(pin, "pulse") 
    jmp("loop")
    label("pulse")
    mov(osr, invert(x))  # Emit a pulse
    out(pins, 1)
    mov(osr, x)
    out(pins, 1)
    wrap()

sm0 = rp2.StateMachine(0, sm_test, freq=100_000, out_base=opp , in_base=inp, jmp_pin=jmp)
sm0.restart()
sm0.active(1)
while True:
    time.sleep(1)
    print("Running")

Expected behaviour

Expected to output a single pulse on GPIO 2 after every positive going edge of GPIO 17.

Observed behaviour

As written, works as designed.

If the link is changed to link GPIO 17 and 14, and the code changed to read

inp = Pin(13, Pin.IN)
jmp = Pin(14, Pin.IN)

pulses are emitted all the time the input is high. If GPIO 1 is strapped to 3V3, pulses stop. Note GPIO 1 is not referenced in the code.

If GPIO 1 and GPIO 14 are linked it runs as designed. This behaviour continues after a power cycle!

Additional Information

RP2350 behaves similarly except that the sensitivity to GPIO 1 is lacking.

The decorator arg is necessary for the code to work. If this is intended it should be documented as this seems unexpected.

Code of Conduct

Yes, I agree

Keyboard

j / / n
next pair
k / / p
previous pair
1 / / h
show query pane
2 / / l
show candidate pane
c
copy suggested comment
r
toggle reasoning
g i
go to index
?
show this help
esc
close overlays

press ? or esc to close

copied