QUERY · ISSUE

oofatfs now uses FF_FS_REENTRANT

openby dhalbertopened 2024-09-03updated 2024-09-03

bug

Port, board and/or hardware

anything using vfs_fat.c

MicroPython version

v1.23 and more recent

Reproduction

extmod/vfs_fat.c still has a couple of #if _FS_REENTRANT, but all the code in lib/oofatfs/ switched to FF_FS_REENTRANT years ago. So I think this was an edit that should have been made but was not.

We noticed this when merging MicroPython into CircuitPython during the last couple of merges.

Expected behaviour

Observed behaviour

Additional Information

No, I've provided everything above.

Code of Conduct

Yes, I agree

CANDIDATE · ISSUE

FatFS exFAT is broken.

closedby iabdalkaderopened 2019-01-26updated 2019-02-21

Hi, any interest in updating FatFS to the latest ? It's 2 years old now, and later revisions fix critical bugs (especially the broken exFAT implementation). I could work on a patch, but I will definitely need some help. Here's a list of changes/bug fixes since 0.12b http://elm-chan.org/fsw/ff/updates.txt

Assessment

Q Qwen · high

Issue #15781 reports a specific macro naming inconsistency (_FS_REENTRANT vs FF_FS_REENTRANT) in extmod/vfs_fat.c that causes compatibility issues. Issue #4431 is a feature request to update the entire FatFS library to a newer version to fix exFAT bugs. While both issues concern the FatFS library and vfs_fat component, they address different problems: one is a specific macro migration bug, the other is a request for a library version upgrade. Fixing the macro issue (#15781) does not resolve the exFAT bugs mentioned in #4431, and updating the library (#4431) might or might not include the macro fix. They are related topics but neither resolves the other.

Suggested action

Keep both issues open. #15781 should be addressed as a bug fix for the macro inconsistency. #4431 remains a separate feature request for updating the FatFS library version.