QUERY · ISSUE

mp_obj_class_lookup error

openby heixiaomaopened 2021-11-01updated 2021-11-06

After I rebuilt, there was a problem running the example. I don't know why

assertion "mp_obj_is_dict_or_ordereddict(MP_OBJ_FROM_PTR(type->locals_dict))" failed: file "/home/hxm/Desktop/lv_micropython/py/objtype.c", line 156, function: mp_obj_class_lookup

CANDIDATE · PULL REQUEST

py: Support passing in an OrderedDict to type() as the locals.

mergedby dpgeorgeopened 2020-06-21updated 2020-06-24

py-core

Split off frm #6130, this PR adds support for passing in an OrderedDict for the locals of a new class, using type(name, bases, locals), where locals can now be an OrderedDict.

The changes here introduce a new helper mp_obj_is_dict_or_ordereddict() and update existing code to use it (which decreases code size in extmod/moductypes.c). The actual feature of using OrderedDict as class locals costs 0 bytes.

Assessment

Q Qwen · high

PR #6176 introduced the mp_obj_is_dict_or_ordereddict() helper and added the assertion at py/objtype.c:156 that is firing in the query issue. The PR didn't introduce a bug — it added a correctness check. The query issue is from lv_micropython (a fork), where some type's locals_dict is not being initialized as a proper dict or ordereddict before mp_obj_class_lookup runs. PR #6176 explains why the assertion exists, and its diff is the direct source of the failing assertion, but the root cause of the failure is elsewhere (likely in lv_micropython's binding or initialization code). PR #6176 does not fix or resolve the query issue.

Suggested action

Ask the reporter to check whether this is a stale build artifact issue (mixed object files from before/after PR #6176 was merged), or a bug in lv_micropython's type registration code where a locals_dict is not properly initialized as a dict object. This is a lv_micropython-specific integration issue, not a upstream MicroPython bug.

mp_obj_class_lookup error

py: Support passing in an OrderedDict to type() as the locals.

Keyboard