Passing tests reported as failures with `MICROPY_ERROR_REPORTING_TERSE`
Port, board and/or hardware
Any
MicroPython version
MicroPython v1.26.0-preview.386.g17fbc5abd.dirty
Reproduction
- Clean build your port of choice
- Run the test suite, notice the absence of failures
- Add
#define MICROPY_ERROR_REPORTING (MICROPY_ERROR_REPORTING_TERSE)to your port'smpconfigport.hfile - Clean build the port
- Run the test suite again.
Expected behaviour
All tests that were passing before changing the error reporting level should still pass.
Observed behaviour
I've seen the following tests fail (for example on QEMU/RV32):
micropython/heapalloc_exc_compressed.pymicropython/heapalloc_exc_compressed_emg_exc.pymicropython/native_with.pymicropython/opt_level_lineno.pymicropython/viper_with.pymisc/print_exception.py
Probably there are more of these but are port-specific and haven't encountered them yet.
Additional Information
The issue is that those tests perform an exact string match on the exception message being raised by the interpreter. With the error reporting level changing, the exception message may change, and thus fail perfectly working tests.
I see this issue on a custom port I'm doing where, for space reasons, I've got to keep error reporting verboseness down. This means I cannot get a single clean test run because with the extra space taken by the error messages (and their interpolation) I have to cut out other features to fit things in the allotted flash space.
A similar issue also exists, as in it's not possible to have a clean test run with the port's ROM level set to MICROPY_CONFIG_ROM_LEVEL_MINIMUM as some tests (even in basic) depend on features cut out by that definition.
I don't mind cleaning up those tests to have a more comprehensive pass/fail check and eventually migrate them to unittest if that's required (and putting in the work to make it testable with the minimum feature set, whilst I'm here...), but before starting this I wonder if this is a PR (or multiple PRs, who knows) that will be at least considered for inclusion.
Code of Conduct
Yes, I agree
Incorrect exception type raised when MICROPY_ERROR_REPORTING_TERSE is selected
Hi,
While running the tests on the WiPy I have seen that some of the basic ones fail. I don't know if the best is to raise tickets or submit PRs or both, so please advice. Here's the first one: int1.py
At some point the test expects a ValueError raised, but SyntaxError is thrown instead. Because in parsenum.c line 144:
value_error:
// if lex!=NULL then the parser called us and we need to make a SyntaxError with traceback
if (MICROPY_ERROR_REPORTING == MICROPY_ERROR_REPORTING_TERSE) {
mp_obj_t exc = mp_obj_new_exception_msg(&mp_type_SyntaxError,
"invalid syntax for integer");
raise_exc(exc, lex);
} else {
mp_obj_t exc = mp_obj_new_exception_msg_varg(&mp_type_ValueError,
"invalid syntax for integer with base %d: '%.*s'", base, top - str_val_start, str_val_start);
raise_exc(exc, lex);
}
I guess that in both cases it should be mp_type_ValueError, right?