QUERY · ISSUE

Socket connect timeout - Feature request

openby Tangerinoopened 2021-11-10updated 2021-11-10

My use case is:

MP is connected to a network where can reach the internet (upstream network) and devices in the LAN (downstream network).
Is known that downstream devices are there and sometimes many, I need to reduce the sock.connect(addr) timeout out so this blocking call does not hang the whole system too much.

So an optional timeout parameter (in msec) would be helpful.

Thank you.

CANDIDATE · PULL REQUEST

extmod/modlwip: Make socket.connect raise ETIMEDOUT on non-zero timeout.

mergedby dpgeorgeopened 2024-06-07updated 2024-06-07

extmod

If the socket timeout is 0 then a failed socket.connect() raises EINPROGRESS (which is what the lwIP bindings already did), but if the socket timeout is non-zero then a failed socket.connect() should raise ETIMEDOUT. The latter is fixed in this commit.

A test is added for these timeout cases.

Also, clean up the timeout logic for socket.accept().

Assessment

S Sonnet · medium

The query requests an optional timeout parameter directly on socket.connect(). The candidate PR fixes socket.connect() to raise ETIMEDOUT (instead of EINPROGRESS) when a pre-set socket timeout expires during a connect attempt. They share the same concern — preventing indefinite blocking in connect() — but via different mechanisms. The PR assumes a timeout already set via settimeout(); the query wants the timeout passed inline to connect(). The candidate does make the existing timeout mechanism functional for connect(), so it partially addresses the user's need, but does not implement what was specifically requested.

Suggested action

Link these for context. The candidate PR resolves the timeout correctness bug in connect(), meaning users can now achieve the desired behavior via sock.settimeout(ms) before sock.connect(). Comment on the issue explaining this workaround. If the request is specifically for a connect(timeout) API signature, that remains open as a separate enhancement. Do not close the issue.

Socket connect timeout - Feature request

extmod/modlwip: Make socket.connect raise ETIMEDOUT on non-zero timeout.

Keyboard