QUERY · ISSUE

ntptime Feature request: Would like to have the ntp server configurable

openby hagenbuchopened 2023-06-14updated 2023-06-28

The timeserver is hardcoded n ntptime.py:

host = "pool.ntp.org"

I would prefer to have this configurable, for several reasons:

There might only be a local network where the node is
DNS might not be available in some cases and under some error conditions
One might as well use a numeric values
Coordinated time might be more important than a real interconnection for embedded devices often involved with logging.

I'm sorry I have no idea (yet) where to start to create a full pull request..

1 comment

massimosala · 2023-06-28

Hi Andreas

It isn't hard-coded.

It is weird they don't put the 'host' as a parameter of the function, but you can do this:

import ntptime
ntptime.host = "your choice"
ntptime.settime()

CANDIDATE · PULL REQUEST

ntptime: support different ntp hosts

closedby puuuopened 2016-05-28updated 2018-03-10

This is useful to choose other area specific ntp pools or a local ntp server (e.g., a router).

Assessment

S Sonnet · medium

The PR directly implements the feature requested in the issue — making the NTP host configurable rather than hardcoded. However, there are two complicating factors: (1) the issue is in micropython/micropython-lib targeting extmod/ntptime.py, while the PR is in micropython/micropython targeting esp8266/scripts/ntptime.py — these are different repos and file locations; (2) the PR merge status is unknown. If the PR was merged into the esp8266 port only, the micropython-lib version may still be unaddressed. The feature intent is identical, but the scope may not fully resolve the lib issue.

Suggested action

Verify if PR #2121 was merged and whether the change was subsequently propagated to micropython-lib's ntptime.py. If both are resolved, close issue #682 as a duplicate. If only the esp8266 port was updated but micropython-lib remains unpatched, the issue is still open.

ntptime Feature request: Would like to have the ntp server configurable

ntptime: support different ntp hosts

Keyboard