Compiling unix build with dupterm support fails on ubuntu
Port, board and/or hardware
unix
MicroPython version
Micropython v1.24.1-dirty (from v1.24-release branch)
Reproduction
git clone -b v1.24-release --depth=1 --single-branch https://github.com/micropython/micropython.git
cd micropython
git submodule update --init
CFLAGS_EXTRA="-DMICROPY_PY_OS_DUPTERM=2" make -C ports/unix
This is executed on a GitHub actions runner (ubuntu-latest).
Expected behaviour
Finish compiling with a working os.dupterm.
Observed behaviour
This exception appears during compilation:
In file included from ../py/runtime.h:29,
from ../py/bc.h:30,
from ../py/emitglue.h:30,
from ../py/compile.h:31,
from ../py/runtime.c:35:
../py/runtime.c: In function ‘mp_init’:
../py/mpstate.h:312:40: error: ‘mp_state_vm_t’ {aka ‘struct _mp_state_vm_t’} has no member named ‘dupterm_objs’
312 | #define MP_STATE_VM(x) (mp_state_ctx.vm.x)
| ^
../py/runtime.c:128:9: note: in expansion of macro ‘MP_STATE_VM’
128 | MP_STATE_VM(dupterm_objs[i]) = MP_OBJ_NULL;
| ^~~~~~~~~~~
-e See https://github.com/micropython/micropython/wiki/Build-Troubleshooting
make[1]: *** [../py/mkrules.mk:90: build/py/runtime.o] Error 1
make[1]: Leaving directory '/home/runner/work/mqterm/mqterm/micropython/mpy-cross'
make: *** [../../py/mkrules.mk:179: ../../mpy-cross/build/mpy-cross] Error 2
make: Leaving directory '/home/runner/work/mqterm/mqterm/micropython/ports/unix'
Additional Information
When compiling locally on my machine (M3 MacBook Pro), setting -DMICROPY_PY_OS_DUPTERM=2 correctly enables os.dupterm support.
Code of Conduct
Yes, I agree
mboot fails to build
Port, board and/or hardware
ARDUINO_PORTENTA_H7
MicroPython version
git describe --dirty: v1.24.0-181-g495ce91ca; Building for ARDUINO_PORTENTA_H7.
But the board says MicroPython v1.25.0-preview.180.g495ce91ca on 2025-01-07; Arduino Portenta H7 with STM32H747 when I flash mpython (it already has mboot I guess).
I've also tried this for tag v1.24.0 and the same error occurs.
Reproduction
Following build instructions from here: https://github.com/micropython/micropython/tree/master/ports/stm32#build-instructions
git clone https://github.com/micropython/micropython.git
cd micropython/
make -C mpy-cross
cd ports/stm32/
make BOARD=ARDUINO_PORTENTA_H7 submodules
make BOARD=ARDUINO_PORTENTA_H7
make -C mboot BOARD=ARDUINO_PORTENTA_H7
Expected behaviour
mboot builds
Observed behaviour
....
....
CC ../../../lib/uzlib/header.c
CC ../../../lib/uzlib/tinflate.c
CC adc.c
CC main.c
main.c: In function 'build_flash_layout_str':
main.c:449:40: error: 'FLASH_LAYOUT_TEMPLATE' undeclared (first use in this function); did you mean 'FLASH_LAYOUT_STR_ALLOC'?
449 | #define FLASH_LAYOUT_STR_ALLOC (sizeof(FLASH_LAYOUT_TEMPLATE))
| ^~~~~~~~~~~~~~~~~~~~~
main.c:453:18: note: in expansion of macro 'FLASH_LAYOUT_STR_ALLOC'
453 | size_t len = FLASH_LAYOUT_STR_ALLOC - 1;
| ^~~~~~~~~~~~~~~~~~~~~~
main.c:449:40: note: each undeclared identifier is reported only once for each function it appears in
449 | #define FLASH_LAYOUT_STR_ALLOC (sizeof(FLASH_LAYOUT_TEMPLATE))
| ^~~~~~~~~~~~~~~~~~~~~
main.c:453:18: note: in expansion of macro 'FLASH_LAYOUT_STR_ALLOC'
453 | size_t len = FLASH_LAYOUT_STR_ALLOC - 1;
| ^~~~~~~~~~~~~~~~~~~~~~
main.c: In function 'pyb_usbdd_StrDescriptor':
main.c:449:40: error: 'FLASH_LAYOUT_TEMPLATE' undeclared (first use in this function); did you mean 'FLASH_LAYOUT_STR_ALLOC'?
449 | #define FLASH_LAYOUT_STR_ALLOC (sizeof(FLASH_LAYOUT_TEMPLATE))
| ^~~~~~~~~~~~~~~~~~~~~
main.c:1191:26: note: in expansion of macro 'FLASH_LAYOUT_STR_ALLOC'
1191 | char buf[FLASH_LAYOUT_STR_ALLOC];
| ^~~~~~~~~~~~~~~~~~~~~~
main.c:1191:22: error: unused variable 'buf' [-Werror=unused-variable]
1191 | char buf[FLASH_LAYOUT_STR_ALLOC];
| ^~~
cc1: all warnings being treated as errors
make: *** [Makefile:295: build-ARDUINO_PORTENTA_H7/main.o] Error 1
make: Leaving directory '........./micropython/ports/stm32/mboot'
Additional Information
Link to offending line in main.c for your convenience: https://github.com/micropython/micropython/blob/master/ports/stm32/mboot/main.c#L449
Code of Conduct
Yes, I agree