QUERY · ISSUE

oofatfs now uses FF_FS_REENTRANT

openby dhalbertopened 2024-09-03updated 2024-09-03

bug

Port, board and/or hardware

anything using vfs_fat.c

MicroPython version

v1.23 and more recent

Reproduction

extmod/vfs_fat.c still has a couple of #if _FS_REENTRANT, but all the code in lib/oofatfs/ switched to FF_FS_REENTRANT years ago. So I think this was an edit that should have been made but was not.

We noticed this when merging MicroPython into CircuitPython during the last couple of merges.

Expected behaviour

Observed behaviour

Additional Information

No, I've provided everything above.

Code of Conduct

Yes, I agree

CANDIDATE · PULL REQUEST

extmod/vfs_fat: Remove support for old block-dev proto with sync/count.

closedby dpgeorgeopened 2018-06-13updated 2018-06-18

This patch removes support in the VFS FAT driver for the old block device protocol. This old protocol used sync and count methods, and was used very early on in the development of the FAT FS driver. Its replacement has been around for a long time and uses the ioctl method to perform all miscellaneous device operations.

This is a breaking change from the Python API point of view, but I don't expect it to have any impact on any scripts because the old block-device protocol was replaced by the new one quick soon after it was introduced.

Code savings for affected ports are:

      stm32:  -140 
     cc3200:  -144 
    esp8266:  -244 
      esp32:  -172