← index #15781Issue #4949
Off-topic · high · value 2.250
QUERY · ISSUE

extmod/vfs_fat.c still uses _FS_REENTRANT, but lib/oofatfs now uses FF_FS_REENTRANT

openby dhalbertopened 2024-09-03updated 2024-09-03
bug

Port, board and/or hardware

anything using vfs_fat.c

MicroPython version

v1.23 and more recent

Reproduction

extmod/vfs_fat.c still has a couple of #if _FS_REENTRANT, but all the code in lib/oofatfs/ switched to FF_FS_REENTRANT years ago. So I think this was an edit that should have been made but was not.

We noticed this when merging MicroPython into CircuitPython during the last couple of merges.

Expected behaviour

Observed behaviour

Additional Information

No, I've provided everything above.

Code of Conduct

Yes, I agree

CANDIDATE · ISSUE

vfs/fat code not working outside micropython

closedby carstenbltopened 2019-07-25updated 2019-07-26

I've been trying to implement threaded C code with file access using the oofat library and I believe that I am failing because it is relying on a micropython function in vfs_fat_diskio.c when using f_read():

mp_call_method_n_kw(2, 0, vfs->readblocks); in disk_read()

At least that is the call where I get the panic. f_open() and f_stat() are working. I do not fully understand all of the code yet, I'd appreciate any help. I don't even know, what function it is calling yet but it should be replaceable.

Keyboard

j / / n
next pair
k / / p
previous pair
1 / / h
show query pane
2 / / l
show candidate pane
c
copy suggested comment
r
toggle reasoning
g i
go to index
?
show this help
esc
close overlays

press ? or esc to close

copied