docs: RP2 DMA some defaults missing/incorrect
Documentation URL
https://docs.micropython.org/en/latest/library/rp2.DMA.html#rp2.DMA.pack_ctrl
Description
The following keys have an incorrect default specified:
bswap(docs claim it'sTrue, but it's actuallyFalse)
The following keys do not have defaults specified:
ring_size(should be0)ring_sel(should beFalse)treq_sel(should be63or0x3f)- Would be good to add a note explaining this, since it's not listed in the DREQ table in the datasheet.
write_err(should beFalse)read_err(should beFalse)
Code of Conduct
Yes, I agree
docs: I2C default pins 4,5 not 8,9 for the RP2 port
Documentation URL
https://github.com/micropython/micropython/blob/6fee099cae58644ea49ca0f470e9cb00a7da8f29/docs/rp2/quickref.rst?plain=1#L339
Description
In the quickref for RP2 (Raspberry Pi Pico family) it has a line of code under Hardware I2C bus:
i2c = I2C(0) # default assignment: scl=Pin(9), sda=Pin(8)
Unless I'm missing something I'm pretty sure this should be:
i2c = I2C(0) # default assignment: scl=Pin(5), sda=Pin(4)
That would agree with the board pinout diagram -- see the dark blue areas. It also agrees with an actual device that I just wired up. I haven't found this association anywhere else yet. It might be in the RP2350 datasheet but I got lost in there.
Caution about pin number confusion. The id numbers passed to the machine.Pin constructor are NOT chip pin numbers or board pin numbers. They refer to GPIOnn aka GPnn signal names. So Pin(5),Pin(4) refer to GPIO5,GPIO4 aka GP5,GP4.
Code of Conduct
Yes, I agree