← index #16088PR #4525
Off-topic · high · value 1.605
QUERY · ISSUE

Checksum Verification for nRF BLE Stack Downloads

openby nmccamishopened 2024-10-26updated 2025-03-19
enhancement

Description

The download script for the nRF BLE stack does not perform checksum verification of any of the downloads. Obviously the checksums would have to be updated every time we bump the stack versions needed, but this could add some extra safety against, for instance, botched downloads.

In addition, much of the bash code is duplicative, and could be refactored.

Code Size

As the sha256sum etc commands are part of coreutils, I do not see this adding any additional dependencies, plus the refactoring should result in less code size / maintenance costs.

Implementation

I intend to implement this feature and would submit a Pull Request if desirable

Code of Conduct

Yes, I agree

CANDIDATE · PULL REQUEST

Nrf ble adv fixes

closedby glennrubopened 2019-02-19updated 2019-02-20

Issue found in testing of new s132/s140 v6.1.1 Bluetooth stack integration while verifying BLE REPL module. The advertisment data on-air was basically garbage which indicated something wrong with the advertisment data configuration. After some testing it turned out that ble_gap_adv_data_t->p_data is not copied by the stack, but rather has to be kept in persistent RAM even after sd_ble_gap_adv_set_configure() has been issued. Not able to reproduce the bug in current master, but the patch is backwards compatible and tested on top of current master (BLE REPL on microbit/nrf51822, pca10040/nrf52832 and, pca10056/nrf52840).

Keyboard

j / / n
next pair
k / / p
previous pair
1 / / h
show query pane
2 / / l
show candidate pane
c
copy suggested comment
r
toggle reasoning
g i
go to index
?
show this help
esc
close overlays

press ? or esc to close

copied