QUERY · ISSUE

oofatfs now uses FF_FS_REENTRANT

openby dhalbertopened 2024-09-03updated 2024-09-03

bug

Port, board and/or hardware

anything using vfs_fat.c

MicroPython version

v1.23 and more recent

Reproduction

extmod/vfs_fat.c still has a couple of #if _FS_REENTRANT, but all the code in lib/oofatfs/ switched to FF_FS_REENTRANT years ago. So I think this was an edit that should have been made but was not.

We noticed this when merging MicroPython into CircuitPython during the last couple of merges.

Expected behaviour

Observed behaviour

Additional Information

No, I've provided everything above.

Code of Conduct

Yes, I agree

CANDIDATE · PULL REQUEST

OO version of FatFS library

mergedby dpgeorgeopened 2016-06-01updated 2017-02-28

This is work in progress, but comments welcome :)

It adds a variant of the FatFS library which takes a FATFS object (or similar) as the first argument of all functions.

It also modifies (in a minimal but hacky way) the extmod/vfs_fat* code to use it when MICROPY_FATFS_OBJ is defined.

Unix is used for testing and with this PR you can create more than one RAMFS.

Assessment

Q Qwen · medium

Issue #15781 reports a specific bug: extmod/vfs_fat.c uses the deprecated _FS_REENTRANT macro while lib/oofatfs uses FF_FS_REENTRANT, causing a macro mismatch. PR #2140 is a major refactor introducing an object-oriented FatFS variant. While PR #2140 modifies both extmod/vfs_fat.c and lib/oofatfs files, its primary purpose is to enable multiple filesystem instances via an OO API, not to fix the macro naming inconsistency. The PR may incidentally address the macro issue as part of its changes, but it doesn't explicitly target or resolve the specific bug reported in #15781. The issue is about a simple macro rename fix, while the PR is a large architectural change.

Suggested action

Keep issue #15781 open. The PR #2140 is a separate architectural refactor that may or may not fully address the macro naming issue. If the PR's changes include updating _FS_REENTRANT to FF_FS_REENTRANT in extmod/vfs_fat.c, the issue could be closed as resolved. Otherwise, a separate small fix is needed.