QUERY · ISSUE

ESP8266 - 'priority' and 'wake' params in Pin.irq method are not supported

openby rsc1975opened 2017-01-08updated 2022-08-23

port-esp8266

The doc (v1.8.6 and v1.8.7) seems to be wrong for the port esp8266, the parameters priority and wake are not supported, but they appears in the Pin class doc: https://micropython.org/resources/docs/en/latest/esp8266/library/machine.Pin.html

I've seen in the port Pin implementation that those parameters are not supported: https://github.com/micropython/micropython/blob/master/esp8266/machine_pin.c

Besides, there are some constants, like Pin.IRQ_LOW_LEVEL or Pin.IRQ_HIGH_LEVEL that are not in Pin class but they appears in the doc.

It seems that there are some other issues related with doc customizations by port, maybe that are sphinx issues, but I don't think so.

CANDIDATE · ISSUE

ESP32 port missing "hard" kwarg in pin.irq()

openby jedieopened 2018-10-05updated 2025-01-07

enhancementport-esp32

The ESP8266 has hard keyword argument in pin.irq() function. This is missing in ESP32 port.

See also: https://forum.micropython.org/viewtopic.php?p=30748#p30745

Assessment

Q Qwen · high

Both issues concern the Pin.irq() method in MicroPython's ESP port implementations, but they address opposite problems. Issue #2773 reports that the ESP8266 documentation incorrectly claims support for 'priority' and 'wake' parameters that don't exist in the implementation. Issue #4214 reports that the ESP32 port is missing the 'hard' parameter that exists in ESP8266. While both involve Pin.irq() and port-specific API differences, they are not duplicates - one is about documentation errors in ESP8266, the other is a feature request for ESP32. They are related topics within the same code area but address different problems.

Suggested action

Keep both issues open as they address different concerns. Issue #2773 is a documentation fix for ESP8266, while #4214 is a feature request for ESP32. Consider cross-referencing them in comments since they both relate to Pin.irq() port compatibility.

ESP8266 - 'priority' and 'wake' params in Pin.irq method are not supported

ESP32 port missing "hard" kwarg in pin.irq()

Keyboard