QUERY · ISSUE

"requests" does not handle redirection with relative path correctly

openby pluto0x0opened 2024-10-20updated 2024-10-20

In python-ecosys/requests/requests/init.py:183,

The url redirect can be a relative path, which cause the missing of hostname and protocal at redirecting.

CANDIDATE · PULL REQUEST

python-ecosys/requests/requests/init.py: Use the host in the redirect url, not the one in headers.

closedby codemeeopened 2024-12-06updated 2025-04-12

removing the host header when redirect

The host in headers extracted from the original url may not be the same as the host in the redirect url. It shoud use the host in the redirect url, not the one in the headers.

1 comment

dpgeorge · 2025-04-12

Rebased and merged in 43ad7c58fd5fc247c255dacb37ab815ec212ee71

Assessment

S Sonnet · high

Both touch the same redirect-handling code in python-ecosys/requests/init.py around the same lines, but they address distinct bugs. The query reports that relative-path Location headers (e.g. /new-path) lose the scheme and hostname during redirect resolution. PR #942 fixes a different problem: when a redirect goes to a different host, the Host header still carries the original host. The PR adds 2 lines to clear/replace the Host header on redirect; it does not add logic to resolve a relative URL against the original request URL, so the query's reported failure mode remains unaddressed after this PR is merged.

Suggested action

Keep issue #931 open. Reference PR #942 as partial context (same code area, related redirect logic), but note that the relative-URL resolution bug still needs a separate fix — likely urllib.parse.urljoin or equivalent logic applied to the Location header value before following the redirect.

"requests" does not handle redirection with relative path correctly

python-ecosys/requests/requests/__init__.py: Use the host in the redirect url, not the one in headers.

Keyboard

python-ecosys/requests/requests/init.py: Use the host in the redirect url, not the one in headers.